-
Notifications
You must be signed in to change notification settings - Fork 11
Final whatsweb improvements + Adapt to last Upstream change. #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-Make dialogs adapted to phone screen -Allow multiple files upload -Fix items from top right-hand corner contextual menu -Add an app Setting Panel -Make association window (with Qr-code) adapted to phone screen -Minor performance improvement -Minor bug corrections -Clean code
|
@alefnode @Fuseteam @mihaelmilea The .click package built by github for this PR is available here: https://github.com/alefnode/ubports-apps/actions/runs/18997047622/artifacts/4437681650 If you see anything that reproductibly does not work as expected or does not display as expected, don't hesitate to report it. |
|
Everything works great and the scaling of the dialogs is very welcomed! Thank you!! - tested on N100, noble One thing that I don't find is the internal app Settings Panel. |
|
@mihaelmilea When whatsapp is loading you should have a small gear in the top right-hand corner. Simply click on it. |
|
Yes, it works great, I missed that when loading, thank you! |
|
It seems that whatsapp web is currently broken. But even in chromium Desktop. I don't see any chat. Do you have the same issue? Hope that they will solve the problem ASAP. (And I hope that it's not that they have banned my account for using an unoficial client! ) |
|
Same situation here in the browser on linux PC. On my UT phone the app still works but I'm afraid to close it and reopen because maybe it will stop showing me the messages... |
|
It is working now... |
|
Yes but whatsweb seems broken, they have made some changes. |
|
Can you test this version (it should be mostly working): https://github.com/alefnode/ubports-apps/actions/runs/19074111316/artifacts/4463406970 @alefnode It would be good to merge as soon as possible as from my understanding the app is currently broken for the users. |
|
I tested it on noble and it works! |
|
Ps: @alefnode I see that Because you have added me as collaborator I can merge a branch. But you should tell me if you want me to do it when the application breaks because of a change upstream, and that you are not available. |
Next time, you can make it and also creating the tag like v0.x.x should publish it |
|
i'm also an collaborator now, so you can ping me too for merging if adrian isn't available xd |
|
Thank you everyone! 🙂 |
|
There is actually a secondary feature that broke in the chaos of yesterday: searching in the chat-window does not work anymore: the keyboard does not open. I will try to do a small patch later this week. |
Dear Pierre, we are the ones that thank you! |
Here are my final improvements to whatsweb for now:
-Make overlay dialogs adapted to phone screen (Transfer message, delete conversation, chose light/dark theme, new channel,ect...)
-Allow multiple files upload
-Fix buttons from top right-hand corner contextual menu ( stared messages, new group )
-Add an internal app Settings Panel
-Make association window (with Qr-code) adapted to phone screen
-Minor performance improvement
-Minor bug corrections
-Clean code
Hopefully, after that, I will not work on it again until Qt6 release (except if meta makes an upgrade that breaks something).
I don't think that there is any rush to publish it, maybe we can take one week or two to test it, in the daily usage. @alefnode @Fuseteam @mihaelmilea
Other notes:
-Maybe it would be worth updating the screenshots in openstore?
-Maybe it would be worth making a separate github repo just for whatsweb?
-It seems that one of the major feature that lacks to Whatsapp web: calls and videocalls, might be coming one day. That would be great. https://www.engadget.com/big-tech/whatsapp-is-reportedly-bringing-voice-and-video-calls-to-browsers-130026611.html
-I'm working on making Signal-Desktop responsive, and that's very funny but I use a modified version of the js script for whatsweb. Because It has a very similar structure. I hope that you don't mind that I include the script that was initially derived from yours (although highly modified) in an AGPLv3.0 project? @alefnode