Fix Search messages in chat window + adpat fontsize to changes upstream #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Fuseteam @alefnode @mihaelmilea Here is the package built by github. https://github.com/alefnode/ubports-apps/actions/runs/19161733287/artifacts/4496592253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Search messages in chat window + adpat fontsize to changes upstream
This pull request is a minimal correction to fix searching messages in the Chat Window. It is a secondary feature but still very usefull for me. It also includes a small adaptation to Fontsize to match the changes that happened in Whatsapp web this Tuesday in that regard. As you can see the modifications in the code are quite short and limited so I hope it should not have any side-effect.
It should now offer 100% of the functionalities of Whatsapp web, and everything should display correctly.
The only drawback being that it is still a bit slughish, I hope it will improve a bit when upgrading to Qt6 or with other upcoming improvements in the OS, or even optimisations in the code of Whatsapp web itself coming from meta.
This time I hope I will not work on this project, until Qt6 release and that Meta will not release changes that break the thing until then (or if they do at least let it be for enabling calls in whatsapp web 😅) . (I might think one day, about ways for the app to be more resilient and self-adaptative to upstream changes, but not now)