http client url project description by DarkhanShakhan · Pull Request #28 · alem-platform/foundation

DarkhanShakhan · 2024-10-07T09:38:49Z

No description provided.

atlekbai

Хороший проект, но не хватает структурированности по заданиям. Нужно четко разделить каждое задание по отдельному функционалу.

atlekbai · 2024-10-10T05:36:24Z

http-curl/README.md

+curl is a simple yet powerful tool for communicating with servers. Here are some common applications:
+* Fetching Web Pages: You can easily retrieve web pages by running a command like curl https://example.com, which will display the HTML content directly in your terminal.
+* Testing APIs: curl is frequently used to send requests to RESTful APIs. For instance, to fetch user information, you might use curl -X GET https://api.example.com/users/1.
+* Uploading Files: You can upload files to a server using the POST method. For example: curl -X POST -F "file=@/path/to/file" https://upload.example.com.
+* Debugging: You can check server responses and headers with commands like curl -I https://example.com, which retrieves only the HTTP headers.


Примеры вызова curl обернуть между backtick символами, например curl https://example.com

исправил

atlekbai · 2024-10-10T05:38:43Z

http-curl/README.md

+When implementing the project, consider handling options similarly to how curl does. You can find more information about options [here](https://everything.curl.dev/cmdline/options/index.html). 
+
+Additionally, you should map errors to the appropriate exit codes. More details on exit codes can be found [here](https://everything.curl.dev/cmdline/options/index.html). 


Ссылка на error codes ведут на options. Возможно ошибка

исправил ссылку

atlekbai · 2024-10-10T05:39:24Z

http-curl/README.md

+- **Your code MUST be written in accordance with [gofumpt](https://github.com/mvdan/gofumpt). If not, you will be graded `0` automatically.
+- **Your program MUST be able to compile successfully.**
+- **Your program MUST not exit unexpectedly (any panics: `nil-pointer dereference`, `index out of range` etc.). If so, you will be get `0` during the defence.**
+- **Only built-in packages from the Go standard library are allowed, excluding `net/http`.**


Убрать выделение жирным

исправил

atlekbai · 2024-10-10T05:42:21Z

http-curl/README.md

+### Using only HTTP
+
+The program must operate exclusively with the HTTP protocol, without relying on the `net/http` package or external HTTP libraries. Requests should be handled through raw TCP connections.


Перенеси этот текст в Usage, так как это не является отдельным заданием

Исправил

atlekbai · 2024-10-10T05:42:44Z

http-curl/README.md

+### Reading options from a configuration file
+
+Your program should support reading options from a plain text configuration file. The file could look like:
+
+```
+method=GET
+url=http://example.com
+headers=User-Agent: MyClient
+```
+
+You should be able to run the program like this:
+
+```bash
+./http-url -c config.txt
+```


Нужна ссылка на спецификацию config файла

Добавил ссылку

atlekbai · 2024-10-10T05:43:11Z

http-curl/README.md

+./http-url -c config.txt
+```
+
+### Supporting options


Supporting -> Supported

Исправил

atlekbai · 2024-10-10T05:43:28Z

http-curl/README.md

+- **`-d`** or **`data`**: Provide data for a POST request
+- **`-F`** or **`--form`**


data -> --data

Исправил

kimarti · 2024-10-25T05:07:51Z

http-curl/README.md

+
+### Supported HTTP methods
+
+The program must be able to send two types of requests: GET and POST. The desired method can be specified using the -X option.


Стоит подробнее описать, как он будет реагировать допустим на PUT, DELETE. Так как запросы успешно уйдут и отработуют. Вернуть --help message например

Suggested change

The program must be able to send two types of requests: GET and POST. The desired method can be specified using the -X option.

The program should only handle GET and POST requests. Other methodsъ should return a `--help` message to guide users on valid request types. The desired method can be specified using the -X option.

Видимо я пропустил этот момент при прошлой проверке.

Я думаю что будет лучше если поддерживать произвольный (arbitrary) HTTP метод, так как HTTP протокол позволяет отправлять любую строку

добавил

kimarti · 2024-10-25T05:35:02Z

http-curl/README.md

+- If no method is specified, GET is the default.
+- The program must send a POST request if data is provided with the `-d` or `--data` option
+- It must automatically follow up to 5 HTTP redirections (3xx status codes)
+


Добавить, что соединение обязательно должо быть закрыто, а программа завершена после выполнения.

Здесь про запросы, которые не успеют обработаться, или будут обрабатываться ошибочно, что не завершит выполнение программы

atlekbai

Надо добавить таймауты, чтобы можно было передавать как аргумент и чтобы был также дефолтный (например 30 сек).

atlekbai · 2024-10-29T06:55:57Z

http-curl/README.md

+In this project, your primary task is to implement several functionalities found in curl. 
+Your program should be capable of:
+* Communicating with servers using the HTTP protocol
+* Sending GET requests
+* Sending POST requests with additional data
+* Handling redirections
+* Allowing users to customize headers
+* Handling errors
+* Reading options from a plain text configuration file


Здесь нужно отразить что нужно уметь отправлять запросы с любым методом

добавил

atlekbai · 2024-10-29T07:00:41Z

http-curl/README.md

+
+Notes: 
+
+- You are not allowed to use the `net/http` package or external HTTP libraries. All requests must be handled via direct TCP connections.


Suggested change

- You are not allowed to use the `net/http` package or external HTTP libraries. All requests must be handled via direct TCP connections.

- All requests must be handled via direct TCP connections.

Запрет net/http уже есть в General Criteria

atlekbai · 2024-10-29T07:01:28Z

http-curl/README.md

+
+- You are not allowed to use the `net/http` package or external HTTP libraries. All requests must be handled via direct TCP connections.
+- If no method is specified, GET is the default.
+- The program must send a POST request if data is provided with the `-d` or `--data` option


Надо написать что если не указан метод при отправке данных, то используется POST

добавил

atlekbai · 2024-10-29T07:03:35Z

http-curl/README.md

+### Details
+
+The program must display detailed information about the HTTP request and response when `-v` or `--verbose` option specified. This helps in debugging and seeing exactly what’s happening during the HTTP transaction.
+
+Example:
+
+```bash
+./http-curl -X GET -v http://example.com
+```
+
+This will output:
+
+```
+> GET / HTTP/1.1
+> Host: example.com
+> User-Agent: your_program/1.0
+> Accept: */*
+< HTTP/1.1 200 OK
+< Content-Type: text/html
+< Content-Length: 1024
+...
+```
+


Давай уберем этот пункт. Он слишком сложен, так как есть разные verbosity levels, сложные сообщения при работе с SSL

atlekbai · 2024-10-29T07:05:07Z

http-curl/README.md

+
+### 1. Plan Before You Code
+
+Before jumping into writing code, take a step back and plan out what you're going to do. Think about the idea first—code comes second. Having a clear plan makes coding smoother and helps avoid problems later on.


Suggested change

Before jumping into writing code, take a step back and plan out what you're going to do. Think about the idea first—code comes second. Having a clear plan makes coding smoother and helps avoid problems later on.

Before jumping into writing code, take a step back and plan out what you're going to do. Think about the idea first — code comes second. Having a clear plan makes coding smoother and helps avoid problems later on.

исправил

adds readme

d97e8cd

atlekbai requested changes Oct 10, 2024

View reviewed changes

DarkhanShakhan added 3 commits October 18, 2024 00:21

fixes comments

e1e2e18

Merge branch 'alem-platform:main' into main

a3f62e9

updates mandatory part

b704da7

kimarti reviewed Oct 28, 2024

View reviewed changes

atlekbai requested changes Oct 29, 2024

View reviewed changes

fixes comments

e429b6f

		When implementing the project, consider handling options similarly to how curl does. You can find more information about options [here](https://everything.curl.dev/cmdline/options/index.html).

		Additionally, you should map errors to the appropriate exit codes. More details on exit codes can be found [here](https://everything.curl.dev/cmdline/options/index.html).

		### Using only HTTP

		The program must operate exclusively with the HTTP protocol, without relying on the `net/http` package or external HTTP libraries. Requests should be handled through raw TCP connections.

		- `-d` or `data`: Provide data for a POST request
		- `-F` or `--form`


		### Supported HTTP methods

		The program must be able to send two types of requests: GET and POST. The desired method can be specified using the -X option.

	The program must be able to send two types of requests: GET and POST. The desired method can be specified using the -X option.
	The program should only handle GET and POST requests. Other methodsъ should return a `--help` message to guide users on valid request types. The desired method can be specified using the -X option.


		Notes:

		- You are not allowed to use the `net/http` package or external HTTP libraries. All requests must be handled via direct TCP connections.

	- You are not allowed to use the `net/http` package or external HTTP libraries. All requests must be handled via direct TCP connections.
	- All requests must be handled via direct TCP connections.


		### 1. Plan Before You Code

		Before jumping into writing code, take a step back and plan out what you're going to do. Think about the idea first—code comes second. Having a clear plan makes coding smoother and helps avoid problems later on.

Conversation

DarkhanShakhan commented Oct 7, 2024

Uh oh!

atlekbai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

atlekbai Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

atlekbai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

atlekbai Oct 29, 2024 •

edited

Loading