Various Code Improvements for Added Stability#12
Open
alexsomeoddpilot wants to merge 37 commits intoalexblack:masterfrom
alexsomeoddpilot:master
Open
Various Code Improvements for Added Stability#12alexsomeoddpilot wants to merge 37 commits intoalexblack:masterfrom alexsomeoddpilot:master
alexsomeoddpilot wants to merge 37 commits intoalexblack:masterfrom
alexsomeoddpilot:master
Conversation
Indentation should be consistent. The dominant usage is two spaces, so I've converted all tab characters to spaces.
Strict mode ensures consistent behavior with newer browsers. Its useful in development to keep issues in check. Compilers/minifiers will remove it eventually for production. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions_and_function_scope/Strict_mode
I've reformatted the comments to a simpler, consistent format for use with Docco to create a simple documentation.
Lines should ideally be less than 85 characters
It doesn't matter immensely, but creates consistency with other comparisons.
…astbutton Conflicts: .travis.yml
…astbutton Conflicts: tests/tests.js
Add UMD boilerplate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made these improvements pending some bigger shifts.