Attempt to make the plugin work again in newer Eclipse releases #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Raised plugin version number to (non-official) 0.6.0. - Upgraded Maven build plugins to recent versions. - Upgraded depencencies (including Eclipse API) to a recent version. Dependency versions are now managed by the parent POM. - Upgraded to Java 17. - Fixed code to compile against the new API and replaced deprecated calls with their respective substitutions. - Fixed unit tests to also run successfully on a Windows system. - Commented out Tycho Build Timestamp from JGit in packaging step because it was not working on my end. - Commented out SonarQube Scanner in build because I am not the official repository maintainer and the currently configured endpoint seems unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin stopped applying/syncing external configurations sometime around Eclipse 2022-12. I have done some upgrades to tooling and dependencies and built the plugin locally. With this local version, it is working again correctly (as of Eclipse 2023-06).
These are the changes I made:
There were a few steps that I did not manage to solve cleanly, so I just worked around them to be able to build the plugin locally: