Solution for Challenge 3#85
Open
algotables wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
Open
Solution for Challenge 3#85algotables wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
algotables wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
Conversation
This commit fixes issues in the HelloWorldClient setup and its interaction with the Algorand blockchain: - Modified the HelloWorldClient constructor to correctly include algod client and adjust the creatorAddress to use deployer.addr, aligning with AlgoKit's requirements for typed clients. - Corrected the createApplication method call to remove an erroneous additional 'create.' prefix and ensured proper parameters in the helloWorld method. - Replaced placeholder 'YOUR_NAME' with 'Jeff' in the helloWorld method call for practical testing. These changes ensure that the client is initialized correctly and interacts with the Algorand blockchain as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Bug Submission Pull Request
What was the bug?
The initial implementation of the
HelloWorldClientin our Algorand-based application contained several bugs related to improper client instantiation and method calls. Specifically:How did you fix the bug?
Client Initialization:
HelloWorldClientinstantiation to correctly include thealgodclient as part of its parameters. This ensures that the client is properly set up to interact with the Algorand network.creatorAddressparameter to usedeployer.addr, providing the correct address format required by the client.Method Call Adjustment:
helloWorldmethod call to use hardcoded "Jeff" as a name parameter, replacing the 'YOUR_NAME' placeholder. This was done to facilitate immediate testing and validation.Code Testing:
helloWorldmethod interacts as expected without errors.Console Screenshot: