Skip to content

index.ts lines 46 and 47: Changed second parameter in addTransaction calls to makeBasicAccountTransactionSigner(signer) instead of just sender#56

Open
rolandgalibert wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
rolandgalibert:main
Open

index.ts lines 46 and 47: Changed second parameter in addTransaction calls to makeBasicAccountTransactionSigner(signer) instead of just sender#56
rolandgalibert wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
rolandgalibert:main

Conversation

@rolandgalibert
Copy link

  1. The code for coding challenge Convert sender to TransactionSigner. #4 is failing with the error TypeError: signer is not a function
  2. On lines 46 and 47 of the original code, sender, an account object, is being used as the second parameter for the addTransaction call. This parameter needs to be a signer object. The algo SDK function makeBasicAccountTransactionSigner can be used to get the signer for the sender object (in other words, the second parameter in both calls should be changed to algosdk.makeBasicAccountTransactionSigner(sender)).

Screenshot from 2024-04-01 06-58-20

…calls to makeBasicAccountTransactionSigner(signer) instead of just sender
@iskysun96
Copy link
Contributor

🎉 Congrats on solving the 4th Algorand Coding Challenge!

I have labeled your PR approved, so you can now claim your certificate.

You can claim your certificate of completion NFT here:
https://goplausible.xyz/claim/8x3aqnmh7p2wf25dvmxz7ksvjs3gr02d6648tf31ny90wwtams53jvssjwcj2bgfs7qr425958h3abw83a33t3tdbqb0sjtntmta82r

@rolandgalibert
Copy link
Author

Hi Chris - I was hoping you might be able to help me, I'm getting a "Your claim has been rejected by Github verifier on this PLAUS! No matching PR, or PR is already claimed!" error when I try to claim my NFT for coding challenge #4. I have successfully claimed the NFTs for the other challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants