index.ts lines 46 and 47: Changed second parameter in addTransaction calls to makeBasicAccountTransactionSigner(signer) instead of just sender#56
Open
rolandgalibert wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
Conversation
…calls to makeBasicAccountTransactionSigner(signer) instead of just sender
Contributor
|
🎉 Congrats on solving the 4th Algorand Coding Challenge! I have labeled your PR approved, so you can now claim your certificate. You can claim your certificate of completion NFT here: |
Author
|
Hi Chris - I was hoping you might be able to help me, I'm getting a "Your claim has been rejected by Github verifier on this PLAUS! No matching PR, or PR is already claimed!" error when I try to claim my NFT for coding challenge #4. I have successfully claimed the NFTs for the other challenges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeError: signer is not a functionsender, an account object, is being used as the second parameter for theaddTransactioncall. This parameter needs to be a signer object. The algo SDK functionmakeBasicAccountTransactionSignercan be used to get the signer for the sender object (in other words, the second parameter in both calls should be changed toalgosdk.makeBasicAccountTransactionSigner(sender)).