feat(sdk/js): add synchronous PoolManagerSync wrapper (Node.js)#361
Open
wangdengshan wants to merge 1 commit intoalibaba:mainfrom
Open
feat(sdk/js): add synchronous PoolManagerSync wrapper (Node.js)#361wangdengshan wants to merge 1 commit intoalibaba:mainfrom
wangdengshan wants to merge 1 commit intoalibaba:mainfrom
Conversation
- Add runPoolOpSync utility using worker_threads + Atomics.wait to
block the main thread while an async pool operation runs in a
short-lived child worker
- Inline WORKER_SCRIPT (no separate file needed after bundling)
- Add PoolManagerSync with static create() factory, blocking CRUD
methods, close(), and Symbol.dispose support (TC39 explicit
resource management / "using" keyword)
- Export PoolManagerSync from index.ts
- Add 50 tests across 2 test files:
- pool.manager.sync.test.ts: API shape, payload forwarding,
error propagation, post-close guard, connection config forwarding
- pool.manager.sync.runSync.test.ts: WORKER_SCRIPT structure,
WorkerResult shapes, PoolOp union, error reconstruction
wangdengshan
requested review from
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PoolManagerSyncwrapper to the JavaScript/TypeScript SDK for blocking pool management in Node.jsrunPoolOpSyncutility usingworker_threads+Atomics.waitto block the main thread while an async pool operation runs in a short-lived child workerWORKER_SCRIPT(no separate file needed after bundling)PoolManagerSyncwith staticcreate()factory, blocking CRUD methods,close(), andSymbol.disposesupport (TC39 explicit resource management /usingkeyword)PoolManagerSyncfromindex.tsTesting
pool.manager.sync.test.ts: API shape, payload forwarding, error propagation, post-close guard, connection config forwardingpool.manager.sync.runSync.test.ts: WORKER_SCRIPT structure, WorkerResult shapes, PoolOp union, error reconstructionBreaking Changes
Checklist