Skip to content

fix(execd): return 404 for missing code contexts#373

Merged
Pangjiping merged 1 commit intoalibaba:mainfrom
liuxiaopai-ai:codex/issue-35-context-404
Mar 6, 2026
Merged

fix(execd): return 404 for missing code contexts#373
Pangjiping merged 1 commit intoalibaba:mainfrom
liuxiaopai-ai:codex/issue-35-context-404

Conversation

@liuxiaopai-ai
Copy link
Contributor

Summary

  • return ErrContextNotFound from execd runtime when a requested code context is missing
  • map missing-context lookups to HTTP 404 / CONTEXT_NOT_FOUND instead of falling through to a nil dereference path
  • add focused runtime and controller tests for missing context id and missing context lookup

Refs #35

Testing

  • go test ./...

Notes

  • go is not installed in this environment, so execd Go tests could not be run locally.

Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this fix. 😊

@Pangjiping Pangjiping merged commit 35b6563 into alibaba:main Mar 6, 2026
14 of 17 checks passed
@Pangjiping Pangjiping added bug Something isn't working component/execd labels Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component/execd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants