refactor(sdk-python): replace exception name matching with type checks#376
Open
Gujiassh wants to merge 2 commits intoalibaba:mainfrom
Open
refactor(sdk-python): replace exception name matching with type checks#376Gujiassh wants to merge 2 commits intoalibaba:mainfrom
Gujiassh wants to merge 2 commits intoalibaba:mainfrom
Conversation
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
|
plz rebase main and fix ruff check. |
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Gujiassh
force-pushed
the
refactor/python-exception-type-checks
branch
from
3646c87 to
59d824e
Compare
Contributor
Author
|
Done - rebased onto the latest main and cleaned up the ruff import ordering. I also reran local ruff, pyright, and pytest for the Python SDK, and they're all green now. Thanks for the heads-up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isinstance()checks against generatedUnexpectedStatustypes and httpx exception classesUnexpectedStatusandHTTPStatusErrorconversion pathsTesting
uv run pytest tests/test_converters_and_error_handling.py -quv run pyright src/opensandbox/adapters/converter/exception_converter.py