Skip to content

chore(server): pass app_config only to provider factory and providers#382

Open
Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Pangjiping:chore/kubernetes-service
Open

chore(server): pass app_config only to provider factory and providers#382
Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Pangjiping:chore/kubernetes-service

Conversation

@Pangjiping
Copy link
Collaborator

Summary

  • create_workload_provider() now takes (provider_type, k8s_client, app_config)
    instead of separate k8s_config, agent_sandbox_config, ingress_config
  • BatchSandboxProvider and AgentSandboxProvider init take (k8s_client,
    app_config) and read kubernetes/agent_sandbox/ingress from app_config
  • Keep optional informer_factory kwarg for tests
  • Update KubernetesSandboxService call site and all provider tests to use
    app_config fixtures/helpers

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@jwx0925
Copy link
Collaborator

jwx0925 commented Mar 9, 2026

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants