fix(server): use internal endpoint resolution for proxy route#404
Merged
Pangjiping merged 1 commit intoalibaba:mainfrom Mar 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402
Summary
This PR fixes proxy endpoint resolution in
proxy_sandbox_endpoint_request.Previously, the proxy route called
get_endpoint(sandbox_id, port), which may return a non-internal/proxied endpoint depending on runtime configuration. That behavior is incorrect for server-side request forwarding.This change updates the proxy route to explicitly call
get_endpoint(sandbox_id, port, resolve_internal=True), ensuring requests are always forwarded to the sandbox internal endpoint.Tests are updated accordingly:
resolve_internalargumentresolve_internal=Trueis passed in the proxy pathTesting
Executed:
uv run pytest tests/test_routes_proxy.pyuv run pytest tests/test_routes_endpoint_behavior.pyBreaking Changes
Checklist