fix(execd): Add fallback from bash to sh for Alpine-based images#407
Open
Jah-yee wants to merge 1 commit intoalibaba:mainfrom
Open
fix(execd): Add fallback from bash to sh for Alpine-based images#407Jah-yee wants to merge 1 commit intoalibaba:mainfrom
Jah-yee wants to merge 1 commit intoalibaba:mainfrom
Conversation
This addresses issue alibaba#405 by adding a getShell() helper function that first tries bash, then falls back to sh for Alpine-based Docker images that don't have bash installed by default.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
SparkLabScout seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
Thanks for fixes. Please sign CLA and I will review and merge those changes as soon as possible. |
Collaborator
|
Perhaps the ref: https://github.com/alibaba/OpenSandbox/blob/main/components/execd/bootstrap.sh
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #405 by adding a fallback from bash to sh for Alpine-based Docker images.
Problem
In a lot of Docker images like Alpine-based images, they only contain
sh. They do not containbashby default, making it impossible to run any command using the execd.Solution
Added a
getShell()helper function that:bashusingexec.LookPathshif bash is not availableThis change has been applied to both locations where shell commands are executed (lines ~96 and ~231).
Testing
The fix is backward compatible - on systems with bash (like Ubuntu, Debian), it will continue to use bash. On Alpine-based images, it will automatically fall back to sh.