Skip to content

fix(server): strip hop-by-hop proxy headers#408

Open
Gujiassh wants to merge 2 commits intoalibaba:mainfrom
Gujiassh:fix/proxy-response-headers
Open

fix(server): strip hop-by-hop proxy headers#408
Gujiassh wants to merge 2 commits intoalibaba:mainfrom
Gujiassh:fix/proxy-response-headers

Conversation

@Gujiassh
Copy link
Contributor

Summary

  • strip hop-by-hop response headers (including those listed in Connection) from sandbox proxy responses
  • keep proxy streaming response behavior unchanged otherwise

Testing

  • python3 -m py_compile server/src/api/lifecycle.py

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@Pangjiping Pangjiping self-assigned this Mar 10, 2026
@Pangjiping Pangjiping added bug Something isn't working component/server labels Mar 10, 2026
Pangjiping
Pangjiping previously approved these changes Mar 10, 2026
Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gujiassh
Copy link
Contributor Author

Gujiassh commented Mar 10, 2026

Follow-up: also honor Connection:-listed hop-by-hop headers on the request path, so any custom hop-by-hop header names are stripped before proxying. (Minimal diff; same file.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component/server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants