Fix: apply sequence packing loss wrapper in SFT validation#293
Open
XChen-Zero wants to merge 1 commit intoalibaba:mainfrom
Open
Fix: apply sequence packing loss wrapper in SFT validation#293XChen-Zero wants to merge 1 commit intoalibaba:mainfrom
XChen-Zero wants to merge 1 commit intoalibaba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in SFT validation when
use_sequence_packingis enabled.In the current implementation,
train_stepwraps the loss function withSequencePackingSFTLossWrapper, whileval_stepdirectly uses the rawloss function. This causes validation to fail when sequence packing is enabled.
This PR applies the same loss wrapper logic in
val_stepto keep training andvalidation behavior consistent.
Why is this needed?
When
use_sequence_packingis enabled:SequencePackingSFTLossWrapperto correctly handle packed sequencesforward_stepreceives incompatible inputs and validation failsThis leads to runtime errors during validation and makes SFT training with
sequence packing unusable.
Changes
SequencePackingSFTLossWrapperinval_stepwhenuse_sequence_packingis enabledtrain_stepandval_stepBackward Compatibility
use_sequence_packingis disabledRelated Issue
N/A