Test: Complete and enhance test coverage for Utilities and ConfigureP… #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties
This commit significantly improves the test coverage for the
`com.taobao.profile.utils.Utilities` and
`com.taobao.profile.config.ConfigureProperties` classes.
For `Utilities.repleseVariables`:
- Added tests for `VariableNotFoundException` when a variable is not found.
- Added tests for `IllegalArgumentException` when source or context is null.
- Added tests for inputs containing no variables.
- Added tests for various malformed or nested variable expressions (e.g.,
`${incomplete}`, `missing_brace}`, `${var${inner_key}}`) to assert the
actual current behavior of the substitution logic. This includes cases
where keys are parsed as `key}` and where string reconstruction
leads to malformed output for certain nested patterns.
For `ConfigureProperties`:
- Added tests for `getProperty(key)` to ensure a `RuntimeException` is
thrown if a property's value contains an unresolvable variable.
- Added tests for `getProperty(key, defaultValue)` to ensure:
- The default value is returned if the key is absent.
- A `RuntimeException` is thrown if the key is present but its value
contains an unresolvable variable (confirming the default value is
not returned in this scenario).
Additionally, the Java version in `pom.xml` was updated from 1.6 to 1.8
to enable successful compilation and execution of the tests.
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roperties
This commit significantly improves the test coverage for the
com.taobao.profile.utils.Utilitiesandcom.taobao.profile.config.ConfigurePropertiesclasses.For
Utilities.repleseVariables:VariableNotFoundExceptionwhen a variable is not found.IllegalArgumentExceptionwhen source or context is null.${incomplete},missing_brace},${var${inner_key}}) to assert the actual current behavior of the substitution logic. This includes cases where keys are parsed askey}and where string reconstruction leads to malformed output for certain nested patterns.For
ConfigureProperties:getProperty(key)to ensure aRuntimeExceptionis thrown if a property's value contains an unresolvable variable.getProperty(key, defaultValue)to ensure:RuntimeExceptionis thrown if the key is present but its value contains an unresolvable variable (confirming the default value is not returned in this scenario).Additionally, the Java version in
pom.xmlwas updated from 1.6 to 1.8 to enable successful compilation and execution of the tests.