Skip to content

Rewrite imageProcessing app and adding parallelization#2066

Open
servantftransperfect wants to merge 1 commit intodevelopfrom
dev/imageProcessing
Open

Rewrite imageProcessing app and adding parallelization#2066
servantftransperfect wants to merge 1 commit intodevelopfrom
dev/imageProcessing

Conversation

@servantftransperfect
Copy link
Contributor

  • Adding a new imageProcessing module with all the algorithms found previously in main_imageProcessing.cpp
  • All algorithms are contained by classes derivated from class ImageProcess.
  • Rewrite the main_imageProcessing.cpp to use these classes
  • Added support for parallelization of compute on multiple devices.
  • First parallelized chunk is computing the output sfmData and will dry run all the needed algorithms.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request performs a major refactoring of the imageProcessing application, introducing a modular class-based architecture and adding support for parallelization across multiple devices. The changes bump the version from 3.4 to 4.0, reflecting significant breaking changes.

Changes:

  • Introduced a new imageProcessing module with a class hierarchy where each processing algorithm is encapsulated in a separate ImageProcess subclass
  • Rewrote main_imageProcessing.cpp to use the new modular architecture with a pipeline of processing steps
  • Added parallelization support through range-based chunking, allowing the workload to be distributed across multiple iterations
  • Removed support for processing individual images or folder inputs - now only accepts SfMData files as input

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
src/software/utils/main_imageProcessing.cpp Refactored main processing loop to use new class-based pipeline, added parallelization logic with dry-run support for metadata computation
src/aliceVision/imageProcessing/imageProcessing.hpp Defines base ImageProcess class and all concrete processing step classes (exposure, resize, reorient, filters, etc.)
src/aliceVision/imageProcessing/imageProcessing.cpp Implements core image processing algorithms using OpenImageIO
src/aliceVision/imageProcessing/imageProcessing_OpenCV.hpp Defines OpenCV-dependent processing classes (bilateral filter, CLAHE, NLM denoising)
src/aliceVision/imageProcessing/imageProcessing_OpenCV.cpp Implements OpenCV-based image processing algorithms
src/aliceVision/imageProcessing/CMakeLists.txt Build configuration for the new imageProcessing library
src/aliceVision/CMakeLists.txt Adds imageProcessing subdirectory to the build
src/software/utils/CMakeLists.txt Links imageProcessing library to the main executable
meshroom/aliceVision/ImageProcessing.py Updated Python integration to support parallelization and removed deprecated input options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants