Rewrite imageProcessing app and adding parallelization#2066
Open
servantftransperfect wants to merge 1 commit intodevelopfrom
Open
Rewrite imageProcessing app and adding parallelization#2066servantftransperfect wants to merge 1 commit intodevelopfrom
servantftransperfect wants to merge 1 commit intodevelopfrom
Conversation
Contributor
servantftransperfect
commented
Feb 26, 2026
- Adding a new imageProcessing module with all the algorithms found previously in main_imageProcessing.cpp
- All algorithms are contained by classes derivated from class ImageProcess.
- Rewrite the main_imageProcessing.cpp to use these classes
- Added support for parallelization of compute on multiple devices.
- First parallelized chunk is computing the output sfmData and will dry run all the needed algorithms.
There was a problem hiding this comment.
Pull request overview
This pull request performs a major refactoring of the imageProcessing application, introducing a modular class-based architecture and adding support for parallelization across multiple devices. The changes bump the version from 3.4 to 4.0, reflecting significant breaking changes.
Changes:
- Introduced a new
imageProcessingmodule with a class hierarchy where each processing algorithm is encapsulated in a separateImageProcesssubclass - Rewrote
main_imageProcessing.cppto use the new modular architecture with a pipeline of processing steps - Added parallelization support through range-based chunking, allowing the workload to be distributed across multiple iterations
- Removed support for processing individual images or folder inputs - now only accepts SfMData files as input
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/software/utils/main_imageProcessing.cpp | Refactored main processing loop to use new class-based pipeline, added parallelization logic with dry-run support for metadata computation |
| src/aliceVision/imageProcessing/imageProcessing.hpp | Defines base ImageProcess class and all concrete processing step classes (exposure, resize, reorient, filters, etc.) |
| src/aliceVision/imageProcessing/imageProcessing.cpp | Implements core image processing algorithms using OpenImageIO |
| src/aliceVision/imageProcessing/imageProcessing_OpenCV.hpp | Defines OpenCV-dependent processing classes (bilateral filter, CLAHE, NLM denoising) |
| src/aliceVision/imageProcessing/imageProcessing_OpenCV.cpp | Implements OpenCV-based image processing algorithms |
| src/aliceVision/imageProcessing/CMakeLists.txt | Build configuration for the new imageProcessing library |
| src/aliceVision/CMakeLists.txt | Adds imageProcessing subdirectory to the build |
| src/software/utils/CMakeLists.txt | Links imageProcessing library to the main executable |
| meshroom/aliceVision/ImageProcessing.py | Updated Python integration to support parallelization and removed deprecated input options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8fb8b72 to
d7a2a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.