Adjust interface to be compatible with other FC runtime#3
Adjust interface to be compatible with other FC runtime#3nerdyyatrice wants to merge 1 commit intomasterfrom
Conversation
|
Not sure how to make the publish maven thing pass on the CI as I imagine we won't put our AK on the CI machine. |
nerdyyatrice
force-pushed
the
adjust_interface
branch
from
1f91102 to
6c2f0bd
Compare
| public OSSEvent(@JsonProperty("events") Event[] events) { | ||
| this.events = events; | ||
| } | ||
| public OSSEvent.Event events[]; |
There was a problem hiding this comment.
Can we make this private and define the accessor like other fields?
| private String eventVersion; | ||
| private OSSEvent.Event.Oss oss; | ||
| private String region; | ||
| private OSSEvent.Event.RequestParameters requestParameters; |
There was a problem hiding this comment.
I prefer a flat structure instead of nest one. e.g. all other fields are declared under OSSEvent.
So user write OSSEvent.Bucket instead of OSSEvent.Event.Oss.Bucket
| public void setUserIdentity(UserIdentity userIdentity) { | ||
| this.userIdentity = userIdentity; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you implement equals, hashCode and toString methods? Those would be useful to write test and print.
| * @return The function output as a Pojo | ||
| */ | ||
| public O handleRequest(I input, Context context); | ||
| public O handleRequest(I input, Context context) throws Exception; |
|
|
5 participants
No description provided.