Update the states constant for the states to be available per country#73
Open
Kevin14Swoo wants to merge 5 commits intomainfrom
Open
Update the states constant for the states to be available per country#73Kevin14Swoo wants to merge 5 commits intomainfrom
Kevin14Swoo wants to merge 5 commits intomainfrom
Conversation
chinleung
reviewed
Mar 3, 2025
Member
chinleung
left a comment
There was a problem hiding this comment.
@Kevin14Swoo Pourquoi on fait cette modification à la structure ? Le problème que je vois long term avec cette implémentation c'est qu'on ne vas pas pouvoir faire State::QUEBEC admettons. Il va falloir faire CanadaState::QUEBEC.
chinleung
reviewed
Mar 3, 2025
Author
Avant y avait juste les states de Australia et Québec dans le enum States. Quand j'ai ajouté les states complete de Canada, on a un doublon de NT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.