Skip to content

Conversation

@Rastii
Copy link

@Rastii Rastii commented Jan 12, 2015

When I attempted to add this module into an existing angular project, I noticed a ton of errors/warnings using JSHint.

This pull request simply makes JSHint not scream at the code with the following changes:

  • Removed unnecessary semicolons after function declarations.
  • Added missing brackets in conditional statements.
  • Added missing semi colons for closure function declarations.
  • Removed a few function declarations within loops.

As for the function declarations within loops, please let me know if I should change them, I honestly didn't review the code to a full extent; therefore, I wouldn't know the best naming conventions for said anonymous functions.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant