Use OsStr::as_encoded_bytes
#41
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenap
force-pushed
the
as-encoded-bytes
branch
3 times, most recently
from
9ff4bea to
57f401f
Compare
allenap
force-pushed
the
as-encoded-bytes
branch
from
57f401f to
7fbb3b6
Compare
allenap
force-pushed
the
as-encoded-bytes
branch
from
7fbb3b6 to
df9d744
Compare
i.e. `OsString::from_encoded_bytes_unchecked` too, where it's safe. `OsStr`/`OsString` are always encoded as a superset of UTF-8, on all platforms. For shells where we can guarantee UTF-8 output, i.e. `bash`/`zsh` and `fish`, we can use these cross-platform methods. For `sh`, where we cannot guarantee UTF-8, then `OsStr`/`OsString` is only available on Unix platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow for better cross-platform support, esp. for Windows.