fix(csharp): preserve namespace scope chain for ref resolution#374
Open
RodgeFu wants to merge 2 commits intoalloy-framework:mainfrom
Open
fix(csharp): preserve namespace scope chain for ref resolution#374RodgeFu wants to merge 2 commits intoalloy-framework:mainfrom
RodgeFu wants to merge 2 commits intoalloy-framework:mainfrom
Conversation
Contributor
|
All changed packages have been documented.
Show changes
|
commit: |
| * hierarchy, stopping at the `stopAt` namespace symbol (which is already in | ||
| * scope from an enclosing NamespaceScopes). | ||
| */ | ||
| function wrapWithNamespaceScopes( |
Collaborator
There was a problem hiding this comment.
I see we already do that in NamespaceScopes can we maybe reuse that component instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Namespacerendering insideSourceFileto preserve full namespace scope chain for dotted namespacesusingand over-qualified member access)Validation
npx vitest run packages/csharp/src/components/namespace/namespace.test.tsx packages/csharp/src/components/namespace.ref.test.tsxCloses #373