Merged
Conversation
Fixes #9, supercedes #8 The test fixtures/resources are now copied to avoid modifying the global cache, requiring a standalone build step to modify the file permissions. Same goes for the `clar` source. The previous ~hack~implementation worked since the libgit dependency path, and by extension the `test/resources` subpath, was known at configure-time. It was also an obvious misuse of the build API. Now that it depends on the final fixtures path it's not possible to pass the flag at configure-time. So instead a standalone build step replaces *reads* of the `CLAR_FIXTURE_PATH` macro in the source with the final path. Two bugs, one stone. Stdio polling was removed from `ClarTestStep` for simplicity. It's probably more efficient too since it's not spinning on a syscall. We'll have to wait until the MbedTLS dependency is updated to zig 0.15.1 before merging.
That's what git blame is for!
fix paths in build.zig.zon
mbedtls was merged ;-)
In `0.15.2` `takeDelimiterExclusive()` was changed to not advance the seek position past the delimiter, causing infinite loops when used as a while condition without manually `toss()`-ing the delimiter. `takeDelimiter()` has the intended behavior and is used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9, supersedes #8
The test fixtures/resources are now copied to avoid modifying the global cache, requiring a standalone build step to modify the file permissions.
Same goes for the
clarsource. The previoushackimplementation worked since the libgit dependency path, and by extension thetest/resourcessubpath, was known at configure-time. It was also an obvious misuse of the build API.Now that it depends on the final fixtures path it's not possible to pass the flag at configure-time. So instead a standalone build step replaces reads of the
CLAR_FIXTURE_PATHmacro in the source with the final path. Two bugs, one stone.Stdio polling was removed from
ClarTestStepfor simplicity. It's probably more efficient too since it's not spinning on a syscall.Merge checklist