Fix errors.json logging ENOENT: no such file or directory#2332
Merged
colinrotherham merged 2 commits intomainfrom Sep 18, 2023
Merged
Fix errors.json logging ENOENT: no such file or directory#2332colinrotherham merged 2 commits intomainfrom
ENOENT: no such file or directory#2332colinrotherham merged 2 commits intomainfrom
Conversation
It was possible for `flagError()` to run before the .tmp directory had been created
colinrotherham
force-pushed
the
error-logging
branch
from
618d101 to
6eca885
Compare
colinrotherham
force-pushed
the
error-logging
branch
from
6eca885 to
924d6cb
Compare
BenSurgisonGDS
approved these changes
Sep 18, 2023
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helped me find and fix an issue in #2306
Before that I was stuck with this error in the terminal:
Error: ENOENT: no such file or directory, open '/private/var/folders/2k/ws6lqbf57d75yf8xt7tt_bqc0000gn/T/test-prototype/.tmp/errors.json'My issue had crashed early enough to confirm:
flagError()can run before .tmp directory existswriteJsonSync(errorPath, { error })This PR stops that from happening