Skip to content

Fix for main thread checker #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumanc wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix for main thread checker #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions ASScreenRecorder/ASScreenRecorder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,16 +296,16 @@ - (void)writeVideoFrame
[self.delegate writeBackgroundFrameInContext:&bitmapContext];
}

CGFloat width = _viewSize.width;
CGFloat height = _viewSize.height;
if(SYSTEM_VERSION_GREATER_THAN_OR_EQUAL_TO(@"8") && UIInterfaceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) {
width = MAX(_viewSize.width, _viewSize.height);
height = MIN(_viewSize.width, _viewSize.height);
}
__block CGFloat width = _viewSize.width;
__block CGFloat height = _viewSize.height;
dispatch_sync(dispatch_get_main_queue(), ^{
if(SYSTEM_VERSION_GREATER_THAN_OR_EQUAL_TO(@"8") && UIInterfaceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) {
width = MAX(_viewSize.width, _viewSize.height);
height = MIN(_viewSize.width, _viewSize.height);
}

// draw each window into the context (other windows include UIKeyboard, UIAlert)
// FIX: UIKeyboard is currently only rendered correctly in portrait orientation
dispatch_sync(dispatch_get_main_queue(), ^{
UIGraphicsPushContext(bitmapContext); {
for (UIWindow *window in [[UIApplication sharedApplication] windows]) {
[window drawViewHierarchyInRect:CGRectMake(0, 0, width, height) afterScreenUpdates:NO];
Expand Down Expand Up @@ -355,14 +355,15 @@ - (CGContextRef)createPixelBufferAndBitmapContext:(CVPixelBufferRef *)pixelBuffe
CGAffineTransform flipVertical = CGAffineTransformMake(1, 0, 0, -1, 0, _viewSize.height);
CGContextConcatCTM(bitmapContext, flipVertical);

if(SYSTEM_VERSION_GREATER_THAN_OR_EQUAL_TO(@"8") && UIInterfaceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) {
CGContextRotateCTM(bitmapContext, M_PI_2);
CGContextTranslateCTM(bitmapContext, 0, -_viewSize.width);
}
if(SYSTEM_VERSION_LESS_THAN(@"8") && [UIApplication sharedApplication].statusBarOrientation == UIInterfaceOrientationLandscapeLeft) {
CGContextRotateCTM(bitmapContext, M_PI);
}

dispatch_sync(dispatch_get_main_queue(), ^{
if(SYSTEM_VERSION_GREATER_THAN_OR_EQUAL_TO(@"8") && UIInterfaceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) {
CGContextRotateCTM(bitmapContext, M_PI_2);
CGContextTranslateCTM(bitmapContext, 0, -_viewSize.width);
}
if(SYSTEM_VERSION_LESS_THAN(@"8") && [UIApplication sharedApplication].statusBarOrientation == UIInterfaceOrientationLandscapeLeft) {
CGContextRotateCTM(bitmapContext, M_PI);
}
});
return bitmapContext;
}

Expand Down