Closed
Conversation
- Replace os.system calls with subprocess.run(check=True) to ensure safer, failing subprocess execution. - Introduce filelock.FileLock-based locking in pcntoolkit/dataio/norm_data.py (replace fcntl) and add filelock dependency to pyproject.toml to provide cross-platform atomic file writes. - normalize task_id timestamp separators to avoid colon characters. - Update tests (test_error_handling.py) to import sys and skip a permission-based test on Windows.
Allows it to work with windows, when make command is called by Git Bash
These instructions tell copilot about how the repo is structured, and also includes additional information about how to set it up in windows
Collaborator
Author
|
After discussion with the team, we decided that Windows support is very low priority, so it won't be implemented. The main reasons are:
** The error related to BLAS that appears in Windows and not Linux: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes I can run pcntoolkit on windows, we still need to discuss if we want to go forward with that and also test again if this branch works fine in Unix too.
Checks:
examples/folder (same as the ones in the websire) run successfully.