Fix dloglik crash when using CG optimizer with warped BLR models#379
Merged
contsili merged 3 commits intoamarquand:devfrom Feb 24, 2026
Merged
Fix dloglik crash when using CG optimizer with warped BLR models#379contsili merged 3 commits intoamarquand:devfrom
contsili merged 3 commits intoamarquand:devfrom
Conversation
…models to prevent dloglik crash
Collaborator
|
very good catch! I only improved the error message inside the |
contsili
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
dloglikcrash when using CG optimizer with warped BLR modelsDescription
This PR fixes a bug where
BLR.fit()crashed with a misleadingUnknown function dloglikerror when attempting to use thecgoptimizer in combination with a warp function (e.g.,warpsinharcsinh).The root cause was that analytical gradients (
dloglik) are not implemented for warped models. When the user manually selectedoptimizer="cg",fit()passed the unsupporteddloglikfunction to the SciPy optimizer, which resulted in a hard crash during optimization.Changes
BLR.fit()before optimization begins.optimizer="cg"is used with a warped model,fit()will:l-bfgs-boptimizer, which correctly uses numerical approximations.WARNINGS.BLR_CG_NOT_SUPPORTED_WITH_WARPinoutput.pyfor clarity.Closes
Closes #378