Open
Conversation
aravindavk
reviewed
Aug 12, 2020
CONTRIBUTING.md
Outdated
| ## Development Workflow | ||
|
|
||
| 0. Fork Repository | ||
| - Visit [GlusterFS repository](https://github.com/gluster/glusterfs) and click 'Fork'. |
Collaborator
There was a problem hiding this comment.
Direct link to Fork https://github.com/gluster/glusterfs/fork
| - Commit changes as a new commit on top of the original commits in the branch, and push the changes to same branch (issueNNNN) | ||
| - Commit changes into the same commit with `--amend` option, and do a push to the same branch with `--force` option. | ||
|
|
||
| 6. Merging: |
Collaborator
There was a problem hiding this comment.
Merge type is "Squash and Merge"?
Owner
Author
There was a problem hiding this comment.
Yes. Only that is permitted. Will update the document
* Make CONTRIBUTING.md have complete workflow documented. * Change './rfc.sh' to reflect the new workflow Updates: gluster/project-infrastructure#62 Change-Id: I31becd7cdb35cb68048b662786c31694791d50fe Signed-off-by: Amar Tumballi <amar@kadalu.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I31becd7cdb35cb68048b662786c31694791d50fe
Signed-off-by: Amar Tumballi amar@kadalu.io