fix double experiment directory creation during training#46
Open
maedmatt wants to merge 1 commit intoamazon-far:mainfrom
Open
fix double experiment directory creation during training#46maedmatt wants to merge 1 commit intoamazon-far:mainfrom
maedmatt wants to merge 1 commit intoamazon-far:mainfrom
Conversation
base_task.py was calling get_timestamp() independently, creating a second experiment directory a few seconds after train_agent.py. Now train_agent.py passes its experiment_dir through EnvConfig so both use the same directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Issue is described in #44
Fix
Pass the
experiment_dircomputed intrain_agent.pythroughEnvConfigtobase_task.pyinstead of havingbase_task.pycompute its own. Added an optionalexperiment_dir: str | None = Nonefield toEnvConfig. Other callers (replay, eval, tests) that don't pass it get the existing fallback behavior.Test plan
ruff checkpassesmypypasses (no new issues)python -m holosoma.train_agent exp:g1-23dof --algo.config.num_learning_iterations=5creates exactly one directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.