Fix infinity in target boxes#116
Open
lemairecarl wants to merge 1 commit intoamdegroot:masterfrom
lemairecarl:fix-infinity
Open
Fix infinity in target boxes#116lemairecarl wants to merge 1 commit intoamdegroot:masterfrom lemairecarl:fix-infinity
lemairecarl wants to merge 1 commit intoamdegroot:masterfrom
lemairecarl:fix-infinity
Conversation
|
I confirm I faced the same issue and fixed it the same way. Still don't know what is a good value for the "tiny shift" (@lemairecarl suggests 1e-10). |
d-li14
added a commit
to d-li14/ssd.pytorch
that referenced
this pull request
Oct 15, 2018
…coded target boxes, zero object detection in , credit to amdegroot#116, amdegroot#144, amdegroot#194
|
Thank you for your inspiration!!! My dataset has just 5 "dirty" data with zero width/height box, now my "inf" problem was solved, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got
-infvalues in my target boxes, which propagated up to the loss. I tracked down this line inencode()where a log is taken on the width/height of the boxes. For some reason, some of my data-augmented boxes have zero-width (or height).It probably happens in the data augmentation, when cropping, with boxes that are on the side of the image. One solution would be to look for zero-width/height boxes and remove them.
But I think it's a good practice to completely remove the risk of
-infby shifting the logarithm a tiny bit, like I do in my suggested change.What do you think?