This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Added GraphQLOperation annotation support.#17
Open
jeremygiberson wants to merge 2 commits intoamericanexpress:masterfrom
Open
Added GraphQLOperation annotation support.#17jeremygiberson wants to merge 2 commits intoamericanexpress:masterfrom
jeremygiberson wants to merge 2 commits intoamericanexpress:masterfrom
Conversation
- set maven default build source/target to 1.7. (should be set to min compile level at least, 1.7 felt safe) - add annotation, tweaked argument annotation to add variable reference - refactor requestentity wrapping top level property w/ operation - added test scenario for working with operations. - todo - more tests to exercise each operation parameter
|
|
Author
|
Btw, do you have recommendation on how to run style linting locally so I don't have to push & wait for travis ci to check fixes? |
Contributor
|
Hey @jeremygiberson, thanks for opening the PR! I really like the idea of adding the operation, this makes it a lot clearer on what the root node of the property tree we are building is instead of checking for null fields. To run the tests with checkstyle + coverage checks I recommend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #16