[improvements] CMake files improvements#65
Closed
jesuschristservant wants to merge 1 commit intoamhndu:masterfrom
Closed
[improvements] CMake files improvements#65jesuschristservant wants to merge 1 commit intoamhndu:masterfrom
jesuschristservant wants to merge 1 commit intoamhndu:masterfrom
Conversation
- FindSFML.cmake: improve SFML version obtention
- CMakeLists.txt: use ${PROJECT_NAME} to avoid repeating SimpleNES
Owner
|
Why is this required? The previous one was vendored directly from official SFML distribution and was known to work on mac/linux/windows (check ci pipelines). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake improvements
Reason of Changes
FindSFML.cmakeThe current regex matches the entire file up to and after the desired line.
Now we safely first extract the line containing the macro and then extract the version number.
CMakeLists.txt${PROJECT_NAME}to set the name of the project at one place.Tests