Skip to content

Conversation

@eu359
Copy link

@eu359 eu359 commented Dec 18, 2025

Checklist

Hi,

My colleague Joss Alvarado and I are opening this pull request in ffmprovisr. This pull request contains previous work from a 2023 pull request made by Juliana Principe and Julia Delgadillo. We have corrected typos and terminology that were previously pointed out by Reto Kromer. We also added new Spanish translations for the following sections: Change or view audio properties, View or strip metadata, Use OCR, Work with interlaced video, and Join, trim, or create an excerpt.

I've referred to the Guidelines for contributing

Thank you,
Emily and Joss

eu359 added 28 commits December 17, 2025 16:37
translated "Join (concatenate) two or more files of different types" recipe
translated the Split one file into several smaller segments recipe
translated the "Trim a video without re-encoding" recipe
translated the "Create an excerpt, starting from the beginning of the file" recipe
translated the "Create a new file with the first five seconds trimmed off the original" recipe
translated "Create a new file with the final five seconds of the original" recipe
translated "Trim silence from the end of an audio file"
translated "inverses audio phase of the second channel"
translated "calculate loudness levels"
translated "RIAA Equalization"
translated "CD De-emphasis"
translated one pass norm, two pass norm, and fix AV sync recipes
fixed syntax in 75
eliminated extras space on line 103
fixed visibility in 104
translated "Deinterlace video"
translated identify interlacement, set field order for interlaced video, inverse telecine, and interlace video fields to frames
added text to line 57 introduction
changed "ruta y nombre" to "ruta, nombre y extensión"
1443 file path
corrected file path 1443
line 1 syntax
@kfrn
Copy link
Member

kfrn commented Dec 22, 2025

Damn this is a huge amount of work! I'm very impressed by all of the effort you have put in to translate. Amazing stuff 🏆

I'm very in favour of seeing ffmprovisr reach other languages, but I'm sorry, I do think we'd need some more work to get this into a mergeable state.

In the current diff:

  • I see a lot of commented-out markup, mostly in English, but also at least one Spanish entry
  • The recipes.txt output file is still in English, as are the shell scripts in ffmprovisr_spanish/scripts
    • I could probs sort this, but I'd recommend to just leave this all out entirely for the time being
  • There's a new file, recipes.md - where did this come from and do we need it?

Also (and I'm aware that I probably sound like a broken record at this point, sorry fellow maintainers), a tidier commit history would make this a lot easier to review - not just in terms of content, but also in following the approach and thinking of the MR.

However, I think all of this points to a larger conversation: how to best structure a project like this to accommodate multiple languages. (Side note: my side project reel time is multilingual, but that is written and structured really differently...)

This topic has come up before with ffmprovisr:

To summarise those discussions, the technical approach matters a lot here. There's a balance to strike between keeping the simple HTML markup approach (easy to edit, no compilation step), versus a code structure that is better designed for modular recipes, as well as multiple languages.

I lean towards the latter approach and I'd be willing to rewrite in something like React, with an output to an HTML file like the current one. I'd like to know what others think!

@retokromer
Copy link
Member

retokromer commented Dec 23, 2025

The file recipes.txt was used by the FFcommand_Engine. That’s the reason why I added it on Tommy Aschenbach’s request. But this piece of software is no longer maintained. A few months ago, I removed the one-line command I was using to generate the file, as it was no longer working correctly.

I presume, the recipes.md is useless?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants