Open
Conversation
First draft of changes, still need to write tests and update documentation
Also revert to using the VERSION number provided when building via Dist::Zilla
Slight refactor to improve creation of Crypt::PBKDF2 object. It's a shame the encoding method is readonly in that module, else this would be even more simple.
Since we output the raw digest without the salt and iteration count, we should die if they are not specified, rather than using some unknowable default.
|
that is a good request. |
|
+1, this functionality would be very useful (and would close https://rt.cpan.org/Public/Bug/Display.html?id=89570 :) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iteration count is analogous to the
costparameter inDigest::Bcryptand I think it would be useful to able to set it in this module. The default imposed byCrypt::PBKDF2is only 1,000 - which is rather low in 2012 (f.ex iOS uses 10,000 iterations by default)I also believe that it should be a required parameter, rather than defaulting it. If someone relies on the default being 1,000 and that changes upstream in the future, with no way to set it via this module, a whole bunch of user passwords could become unretrievable.
Please consider this pull request the start of a discussion, I think this parameter would be useful - but is not essential, and it does have downsides (the breaking of backwards compatibility)