news notifier for ndtv hindi site added#4
Open
ItachiUchiha1998 wants to merge 1 commit intoamitsagtani97:masterfrom
ItachiUchiha1998:master
Open
news notifier for ndtv hindi site added#4ItachiUchiha1998 wants to merge 1 commit intoamitsagtani97:masterfrom ItachiUchiha1998:master
ItachiUchiha1998 wants to merge 1 commit intoamitsagtani97:masterfrom
ItachiUchiha1998:master
Conversation
Author
|
do i need to make changes in the code or is it fine? |
amitsagtani97
requested changes
Oct 14, 2017
Owner
amitsagtani97
left a comment
amitsagtani97
left a comment
There was a problem hiding this comment.
hi, can you please store the news scrapped from ndtv website into the main.py and show in the notifications along with the TOI headlines, instead of creating a new news.py file. News in only English language are preferred. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this is what you were looking for ..