Conversation
- 'install' takes a list of packages to install with apt - 'update' triggers an 'apt update' before the run - setting 'install' will force an update regardless of the 'update' value - 'entrypoint.py' is made unbuffered (by running 'python3 -u') to more accurately interleave the output of various commands
a599454 to
324ac0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to mitigate the issues updating / running
aptin the container, as discussed in #33.It turns out that running arbitrary scripts using
os.system()works... not so well, in practice. So, this PR moves to a more controlled method of managing the container's packages, with two newwith:options added to the action syntax:The added logic goes:
actions.ymldoesn't take yaml sequences directly, but the funky>-syntax tells it to fold newlines into spaces and present the results as a single space-separated list.)The PR also makes two other changes:
sphinxdoc/sphinx:latest, because2.4.4is ancient which is part of the problem. (If people have concerns about tracking a moving-target likelatest, the current is4.3.2and would be a better choice than2.4.4.)entrypoint.pyunbuffered via#!/usr/bin/env -S python3 -u, so that the output ofprint()calls and subcommands is more correctly interleaved.Fixes #33 #32