Adding fail on cache-hit feature#23
Open
stjohnjohnson wants to merge 1 commit intoammuench:masterfrom
Open
Conversation
Per the instructions on the DonorDrive API, we can send the ETag value and get a 304 if the contents have not changed. https://github.com/DonorDrive/PublicAPI/blob/master/overview.md#status-codes I've added the `cacheTag` and `lastModifiedUTC` to the response of getUserInfo. Additionally, an optional `cacheTag` that will cause a rejected promise with "Not Modified" if the cache hits. Additionally, `res.json()` is a promise, so the previous code was unable to access or modify the return value. This also meanth that it would never load the teamURL. Instead of restoring the teamURL functionality, I removed it so that we don't add additional API calls without explict ask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the instructions on the DonorDrive API, we can send the ETag value and get a 304 if the contents have not changed.
https://github.com/DonorDrive/PublicAPI/blob/master/overview.md#status-codes
I've added the
cacheTagandlastModifiedUTCto the response of getUserInfo. Additionally, an optionalcacheTagthat will cause a rejected promise with "Not Modified" if the cache hits.Additionally,
res.json()is a promise, so the previous code was unable to access or modify the return value. This also meanth that it would never load the teamURL. Instead of restoring the teamURL functionality, I removed it so that we don't add additional API calls without explict ask.