Draft
Conversation
mikachan
commented
Aug 5, 2024
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "$schema": "https://schemas.wp.org/wp/6.4/theme.json", | |||
Member
Author
There was a problem hiding this comment.
I've used the 6.4 version of the JSON schema, as this makes it easier to use theme.json settings that are supported up to a specific version of WordPress.
Contributor
|
I want to note that before WordPress 6.6, mixing different style variations containing different settings was not possible. This means that if, for example, a user activates a variation containing only font families and later activates a variation containing only colors, the font families will be removed. As we added style variations for fonts here: #356 we should be mindful of that if the production sites are running Wordpress core versions older than 6.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #335
This is a small PR to provide an example of an alternative colour scheme using the theme.json format.
After looking through the colour names, I don't think any of these need to be changed. I think the colours with descriptive names (Grey Extra Extra Light, Orange, Blue Mid Light) can stay as they are, as these can likely be used across many different colour variations.
The ones that could potentially change are:
Maybe some other semantic colours could be added if there needs to be more flexibility, but I think it's fine to start with these.
This PR shows an example of switching the Primary and Secondary colours around, and I added a different shade of blue for the Secondary State.
Steps to test:
1.
Considerations:
<section>; landmarks; etc.)aria-label,aria-labelledby, etc.)