Open
Conversation
jffng
commented
Aug 9, 2024
| const lastMenuItem = pageHeader.querySelector('.mobile-menu > ul > li:last-of-type'); | ||
| const menuItemClassList = `.${Array.from(lastMenuItem.classList).join('.')}`; | ||
| let previousFocus; | ||
| if ( lastMenuItem ) { |
Author
There was a problem hiding this comment.
This is kind of an unrelated change, but I was getting a scripting error since this was undefined in my test setup.
jffng
commented
Aug 9, 2024
jffng
commented
Aug 9, 2024
| api | ||
| .getPostsFromAuthors(requestArguments, value) | ||
| .then((data = [], i, xhr) => { // eslint-disable-line | ||
| .then((data = [], i, xhr) => { |
Author
There was a problem hiding this comment.
These changes were the result of running yarn lint --fix.
jffng
force-pushed
the
try/wordpress-scripts
branch
from
e8dff12 to
4e1d2d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the build scripts to
@wordpress/scriptsto compile the theme as is. The idea is to simplify the build configuration, and provide an incremental change to allowing the blocks to be upgraded.Ref: #285
Steps to test:
cd privaterm -rf node_modulesyarn && yarn buildConsiderations:
I think the main benefit to this PR is it cuts down on the projects development dependencies. But if you do go ahead with moving the blocks to a separate plugin in the near term, then maybe this PR is not as relevant or useful.