Card Disable() / Enable() update#60
Conversation
Applied fixes from amoffat#38 Fixed an issue where disabled cards were being passed through validation
|
I'm going to be using this Fork until it hits the main branch. I prefer your way of fixing the validation issue to the hack I applied in my personal code. Thanks! |
Changed back button class on first index to .hidden rather than .disabled
Fixed behavior of validation behavior when skipping a disabled tab.
Minified updated code js
|
Upon testing and further review of the code, I don't believe it operates correctly or at least it doesn't for what I am doing. Using the existing code, when I click next and a disabled tab is the next tab then it appears that the ending index is increased by 1 as well as the current index, which means that the landing tab is run through the validation (and fails obviously if it has any validation on it). Also it appears that the initial card is not hidden as both the card I left and the target card displayed. I'm putting in a pull request from a fork I made of this repo that does a disabled check on just the point where validation is run (and returns ok if it is disabled) which when I test functions as desired. |
Bug in Disabled Validation behavior
If an element contains validation the message for the first error is always displayed, any subsequent error messages aren't displayed.
2 participants
Applied fixes from #38
Fixed an issue where disabled cards were being passed through validation