Open
Conversation
added 6 commits
July 28, 2021 12:22
…y string as default, rather than a empty object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if datepicker's field value is empty, update field value with an empty string as default, rather than a empty object. This allow the resource store to correctly count current filters.
Resolving this issue:
I set a date in the picker, page is refreshed with correct results, filters count is displayed as 1

If I try to reset the date field to it's original value, by deleting the date manually, page is refreshed with correct results, but the filter set previously is still detected and counted, even if it's value doesn't interfer in the result. That's because the original value is an empty string, and the value returned by removing a date manually is an empty object.
The resource store does not detect it, and display the resource as filtered.