Use thread-safe map to track active plans.#2
Open
erikrozendaal wants to merge 1 commit intoampedandwired:masterfrom
Open
Use thread-safe map to track active plans.#2erikrozendaal wants to merge 1 commit intoampedandwired:masterfrom
erikrozendaal wants to merge 1 commit intoampedandwired:masterfrom
Conversation
Before whenever two or more plans started simultaneously a deadlock would occur, as each plan found the other already running. This fix uses a thread-safe map to track the plan that currently holds the mutex. When the plan finishes the mutex is cleared. If a plan dies without clearing the mutex a plan awaiting the mutex will perform the cleanup instead. The implementation does assume that the pre- and post-chain actions run in a single JVM. Hopefully this is actually true...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before whenever two or more plans started simultaneously a deadlock would occur, as each plan found the other already running.
This fix uses a thread-safe map to track the plan that currently holds the mutex. When the plan finishes the mutex is cleared. If a plan dies without clearing the mutex a plan awaiting the mutex will perform the cleanup instead.
The implementation does assume that the pre- and post-chain actions run in a single JVM. Hopefully this is actually true...
This fix has been running in our Bamboo installation for a while and works for us without deadlocks. This fixes issue #1.