Conversation
amtep
approved these changes
Feb 20, 2026
Owner
amtep
left a comment
amtep
left a comment
There was a problem hiding this comment.
Found some style issues but nothing to prevent merging :)
| #[cfg(feature = "vic3")] MobilizationOption, | ||
| #[cfg(feature = "vic3")] MobilizationOptionGroup, | ||
| #[cfg(feature = "vic3")] ModifierTypeDefinition, | ||
| #[cfg(any(feature = "vic3", feature = "eu5"))] ModifierTypeDefinition, |
Owner
There was a problem hiding this comment.
This item and its path should be moved to the shared items section
| #[cfg(feature = "vic3")] | ||
| Item::ModifierTypeDefinition => "common/modifier_type_definitions/", | ||
| #[cfg(any(feature = "vic3", feature = "eu5"))] | ||
| Item::ModifierTypeDefinition => match Game::game() { |
Owner
There was a problem hiding this comment.
The match isn't needed since both paths are the same
| #[cfg(feature = "ck3")] BuildingFlag, | ||
| #[cfg(feature = "ck3")] BuildingGfx, | ||
| #[cfg(feature = "ck3")] CasusBelli, | ||
| #[cfg(any(feature = "ck3", feature = "eu5"))] CasusBelli, |
Owner
There was a problem hiding this comment.
This item and its path should be moved to the shared section
| Item::BuildingCategory => "common/building_categories/", | ||
| #[cfg(feature = "eu5")] | ||
| Item::PopType => "common/pop_types/", | ||
| Item::ArtistType => "common/artist_types/", |
Owner
There was a problem hiding this comment.
Would be nice to keep these sections sorted alphabetically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.