Skip to content

Update Client.php to replace depracated methods for newer PHP version#33

Open
Be-Klasen wants to merge 1 commit intoamzn:Legacy-DEfrom
Be-Klasen:patch-1
Open

Update Client.php to replace depracated methods for newer PHP version#33
Be-Klasen wants to merge 1 commit intoamzn:Legacy-DEfrom
Be-Klasen:patch-1

Conversation

@Be-Klasen
Copy link

using iconv_set_encoding is deprecated in PHP>50600. The proposed change checks the PHP version and uses the new method instead when appropriate.

using iconv_set_encoding is deprecated in PHP>50600. The proposed change checks the PHP version and uses the new method instead when appropriate.
@jobbrown
Copy link

Why not version_compare() for this? http://php.net/manual/en/function.version-compare.php

Example:

if(version_compare(PHP_VERSION, '5.6.0') >= 0) {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments