Make whitespace match PSR/2 standard (3.2.0 update)#63
Open
ejegg wants to merge 1 commit intoamzn:masterfrom
Open
Make whitespace match PSR/2 standard (3.2.0 update)#63ejegg wants to merge 1 commit intoamzn:masterfrom
ejegg wants to merge 1 commit intoamzn:masterfrom
Conversation
Author
|
@bjguillot , to review this you might want to use the '-w' switch to 'git diff' or 'git log' That switch will ignore all the changes where whitespace is just inserted or deleted within a single line, and show all the place where braces have been moved to different lines, etc. |
Author
|
Fixes #34 |
Contributor
|
Thanks for the suggestion on the '-w' switch. |
ejegg
force-pushed
the
3.2.0-ws
branch
3 times, most recently
from
2a9fe1b to
2bd2018
Compare
To make future diffs cleaner. Also inserts explicit braces around oneline if statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the recommended standard for PHP libraries
Also inserts missing braces around one-line conditionals and standardizes case of booleans.