Fix plot for model #794
Merged
Fix plot for model #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the import mechanism for the plot function in the torch base mixins module. The change replaces a conditional import using try_import with a direct import from the parent package.
- Replaces conditional import with direct import for the plot function
- Removes dependency on
utils_import.try_importutility - Simplifies the import structure by using a direct relative import
| from ...utils_import import try_import | ||
| plot = try_import(module='...plotter', package=__name__, attribute='plot', | ||
| help='Try `pip install batchflow[image]`!') | ||
| from ... import plot |
There was a problem hiding this comment.
The change from conditional import to direct import removes the graceful fallback behavior. If the plot module is not available, this will now raise an ImportError instead of providing a helpful error message about installing 'batchflow[image]'. Consider whether this breaking change is intentional.
Member
Author
There was a problem hiding this comment.
But plot from batchflow is already lazy import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.