Merged
Conversation
Improve the path mangling part of compile-requirements so that it doesn't leave absolute paths even to comments. Regenerate the requirements-dev.txt and requirements-siptools.txt files with this change.
After the dpres-mets-builder and dpres-siptools-ng were added as dependencies to passari pip-compile didn't know where to find them and therefore wasn't able to recompile the requirements*.txt files. Fix this issue by adding a "-c siptools-deps.txt" line to the requirements.in where the siptools-deps.txt contains the all of the siptools dependencies and their download locations. Also modify the requirements-siptools.in to use that siptools-deps.txt so that the same deps don't have to be specified in two places. Additionally, regenerate the requirements*.txt with these changes.
jopesy
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix requirements to be compilable again and improve absolute path removal
in compile-requirements script.