Added support for the menu API#168
Added support for the menu API#168alexbakker wants to merge 1 commit intoandlabs:masterfrom alexbakker:menu-support
Conversation
|
Menus are not Controls. The current API sucks anyway, but I'm not sure how to make a better one. |
|
Ah yes, looks like some remnant code/comments managed to sneak in. I've fixed it. I agree that the current API is not ideal. At the very least windows should be able to have their own menus. Support for icons and submenus also comes to mind, but that can be added later on. |
|
So, are you going to merge this? If not, please close the PR. |
|
@andlabs After your initial comments, Impyy mentioned that there are now fixes. Would you be interested in merging this so that we can have menus? |
|
The bigger problem is that I plan on changing the menu API in libui itself, so even if I merge this now, it would break very soon. But development on libui is going slowly right now, so I probably could... I want package ui to represent stable points in libui, and I can tell you the text API is about to completely change (the changes are 90% complete at this point; if I can keep up motivation I could have it merged back in by August if not July), so I typically don't touch package ui anymore until a libui stable release. That's why you haven't seen me do anything to this repo. libui PRs are more me dragging my feet and I do need to get better about that :x |
3 participants
No description provided.