Replace label and break with defer and return#2
Open
boppreh wants to merge 1 commit intoandlabs:masterfrom
boppreh:patch-1
Open
Replace label and break with defer and return#2boppreh wants to merge 1 commit intoandlabs:masterfrom boppreh:patch-1
boppreh wants to merge 1 commit intoandlabs:masterfrom
boppreh:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels and outer breaks are not very elegant, so I'm proposing using a simple
returninstead of thebreakand deferring thestop()using a language feature. This makes clear thatstop()is a cleanup action and the code inside the main loop doesn't have to worry about it.