Moving to python3 and SelfControl4#67
Open
Trajjan wants to merge 5 commits intoandreasgrill:masterfrom
Open
Conversation
Owner
|
The issue is that auto-selfcontrol is not fully working with SelfControl 4 at the moment. So I'm not that eager to remove support for v3 and below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some change to make auto-selfcontrol compatible with python 3.
I dropped the support for SelfControl 2 and 3 and just went with 4 (I did not want to change the regex thing , so I just dropped it and supposed it was 4).
I am unsure you’d want to accept this pull request, but it might be of interest to you.